* Add check for cosmic terminal and use different arguments if so
* Changed check for terminal to be strictly against executable name instead of path
based on this comment https://github.com/ArchipelagoMW/Archipelago/pull/6436#discussion_r3994140550
* Add `ptyxis` to list of moddern terminals
Co-authored-by: Duck <[email protected]>
* Changed `-e` terminal launch method to use `sh`
This standardizes the environment in which archipelago components launch and fixes launching with `zutty`
* Properly import pathlib
* Added comment detailing what `modern_terminals` is
* Refactored launching in terminal to new function in utils
* Optimised imports in Launcher.py
* Revert "Refactored launching in terminal to new function in utils"
This reverts commit 43367987da.
* Fixed unintentional cleanup in Utils.py
* Simplify check for terminals
Co-authored-by: Duck <[email protected]>
* Fully import pathlib
* Fix spelling mistake
* added gnome-terminal to list of modern_terminals
* added cosmic-term and ptyxis as fallback terminals
* Changed terminal search to add more terminal names easier
also included `alacritty` and `kitty`
* Check xterm terminal last
Also stores the list of terminals in tuples
Co-authored-by: black-sliver <[email protected]>
* Add type hint to terminal variable
Co-authored-by: black-sliver <[email protected]>
---------
Co-authored-by: Osiris32-and-a-half <[email protected]>
Co-authored-by: Duck <[email protected]>
Co-authored-by: black-sliver <[email protected]>
* Correct Bounce Target logic, write unit tests
tmp
* that is not correct
* What was I smoking
* explicitly document None
* What was I smoking
* fix weakref syntax
* ruff
* fix magicmoc
* Address Berserker's comments
* comment
* consistently use self.assertEqual
* make slot 2 on team 3 not use deathlink to test different tags for the same slot on different teams
* Improve error message
* Re-gen with UT + slim slot_data slightly
* make use of relevance in ut code
* That's not how enums work
* fixup
* more ut compat
* more ut fixup
* more ut fixup
* utils entity hex fixup
* Me when I lie
* Update options.py
* Allow 'and' concatenation of bounce packet conditions
* Docs + small change
* Docs stuff
* update Bounced as well
* lol
* shadowing issue
* Slight rework to allow teams
* teams note
* Make the PR ready
* docs further up too
* Let's not do this actually
* Use operator & don't redefine functions
* team default
* remove unnecessarily added whitespace
* Core: limit depth of received JSON to 16
This applies to both MultiServer and CommonClient.
This means DataStorage default is limited to 14 levels,
DataStorage op arg is limited to 13 levels.
* Core: fix JSON depth limit check for escape codes
* Core: cythonize JSON depth limit check
