Mysteryem dbf2325c01
KH2: Fix placing single items onto multiple locations in pre_fill ( #5619 ) ...
`goofy_pre_fill` and `donald_pre_fill` would pick a random `Item` from a
`list[Item]` and then use `list.remove()` to remove the picked `Item`,
but the lists (at least `donald_weapon_abilities`) could contain
multiple items with the same name, so `list.remove()` could remove a
different `Item` to the picked `Item`, allowing an `Item` in the list to
be picked and placed more than once.
This happens because `Item.__eq__` only compares the item's `.name` and
`.player`, and `list.remove()` compares by equality, meaning it can
remove a different, but equal, instance from the list.
This results in `old_location.item` not being cleared, so
`old_location.item` and `new_location.item` would refer to the same
item.
2025-12-20 22:32:12 +01:00
2025-07-31 21:09:00 +02:00
2025-11-11 23:19:20 +01:00
2025-11-25 00:38:42 +01:00
2025-10-23 05:30:46 +02:00
2025-11-29 19:09:30 +01:00
2025-12-18 00:02:11 +01:00
2025-12-05 01:09:56 +01:00
2025-10-05 05:08:34 +02:00
2025-07-15 16:01:53 -04:00
2025-07-15 16:01:53 -04:00
2025-09-30 03:53:47 +02:00
2025-12-02 00:40:05 +01:00
2025-10-05 06:47:01 +02:00
2025-12-19 14:54:41 +01:00
2025-05-20 20:12:13 +02:00
2025-11-29 19:02:15 +01:00
2025-11-29 18:47:54 +01:00
2025-11-29 19:07:02 +01:00
2025-11-29 19:04:07 +01:00
2025-10-25 22:19:38 +02:00
2025-10-19 03:30:24 +02:00
2025-03-29 17:32:33 +01:00
2025-03-29 17:32:33 +01:00
2025-12-19 14:52:27 +01:00
2025-12-18 07:52:15 +01:00
2025-01-13 18:35:01 -05:00
2025-10-17 16:44:11 +02:00
2025-11-29 19:11:07 +01:00
2025-12-14 17:01:32 +01:00
2025-09-05 16:22:11 +02:00
2025-10-19 03:36:35 +02:00
2025-07-15 16:01:53 -04:00
2024-12-21 23:12:35 +01:00
2025-11-29 19:08:39 +01:00
2025-12-16 19:27:02 +01:00
2025-11-29 18:48:46 +01:00
2025-12-20 22:32:12 +01:00
2025-11-29 18:46:22 +01:00
2025-11-15 03:27:41 +01:00
2025-07-16 23:49:01 -04:00
2025-10-25 22:19:38 +02:00
2025-11-09 19:55:37 +00:00
2025-09-30 03:53:31 +02:00
2025-05-24 00:13:34 +02:00
2025-11-29 18:50:34 +01:00
2025-11-15 02:49:59 +01:00
2025-06-16 07:47:55 -04:00
2025-11-15 03:26:20 +01:00
2025-09-30 04:12:19 +02:00
2025-10-25 22:19:38 +02:00
2025-08-16 17:08:44 -04:00
2025-04-26 13:28:07 -04:00
2025-07-23 23:27:50 +02:00
2025-11-09 19:55:37 +00:00
2025-11-15 02:13:34 +01:00
2025-09-16 19:26:06 +02:00
2024-08-07 23:57:07 +02:00
2025-10-05 06:47:01 +02:00
2025-12-19 23:25:20 +01:00
2025-12-02 00:40:05 +01:00
2025-12-15 00:56:54 +01:00
2025-11-29 19:10:37 +01:00
2025-06-14 09:26:22 -04:00
2025-10-05 05:08:15 +02:00
2025-10-25 22:19:38 +02:00
2025-03-08 12:07:50 -05:00
2025-10-25 22:19:38 +02:00
2025-10-25 22:19:38 +02:00
2025-11-11 18:16:38 +00:00
2025-10-16 22:23:23 +02:00
2025-08-02 21:19:23 +02:00
2025-10-13 18:06:25 +02:00
2025-12-19 21:00:36 +01:00
2025-12-18 00:06:06 +01:00
2025-12-19 14:42:05 +01:00
2025-11-23 01:38:19 +01:00
2024-08-12 01:53:40 +02:00
2025-07-27 10:45:48 -04:00
2025-11-29 18:51:20 +01:00
2025-11-15 16:22:56 +01:00
2025-11-21 23:33:51 +01:00
2025-12-20 13:36:20 +01:00
2025-12-19 14:53:24 +01:00
2025-10-25 22:19:38 +02:00
2025-10-15 01:09:05 +02:00
2025-11-30 01:22:35 +01:00
2025-11-15 16:55:13 +01:00
2025-11-25 00:38:42 +01:00
2025-12-19 14:53:56 +01:00
dbf2325c01