Mysteryem f28aff6f9a Core: Replace generator creation/iteration in CollectionState methods (#4587) ...

* Core: Replace generator creation/iteration in CollectionState methods

Using generators in these functions incurs overhead to create the new
generator instance, call the `any`/`all`/`sum` function and have the
`any`/`all`/`sum` function iterate the generator, which in turn iterates
the iterable.

Replacing the use of generators with for loops is faster.

Getting `self.prog_items[player]` once in advance also improves
performance of iterating longer iterables.

* Add comment on the choice of for loops instead of any()/all()/sum()

2025-02-02 15:25:34 +01:00

78 KiB

Raw Blame History

View Raw