Commit Graph

44 Commits

Author SHA1 Message Date
Silvris
44286dd026 Update Files.py 2024-04-08 16:55:24 -05:00
Silvris
ae86e4f1c6 Merge remote-tracking branch 'upstream/main' into instruction_patch_kdl3 2024-03-24 01:15:43 -05:00
Silvris
218cd45844 APProcedurePatch: fix RLE/COPY incorrect sizing (#3006)
* change class variables to instance variables

* Update worlds/Files.py

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

* Update worlds/Files.py

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

* move required_extensions to tuple

* fix missing tuple ellipsis

* fix classvar mixup

* rename tokens to _tokens. use hasattr

* type hint cleanup

* Update Files.py

* check using isinstance instead

* Update Files.py

---------

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2024-03-22 09:02:38 +01:00
Silvris
401aeaeea4 Merge remote-tracking branch 'upstream/main' into instruction_patch_kdl3 2024-03-20 19:43:53 -05:00
Silvris
f4b7c28a33 APProcedurePatch: hotfix changing class variables to instance variables (#2996)
* change class variables to instance variables

* Update worlds/Files.py

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

* Update worlds/Files.py

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

* move required_extensions to tuple

* fix missing tuple ellipsis

* fix classvar mixup

* rename tokens to _tokens. use hasattr

* type hint cleanup

* Update Files.py

* check using isinstance instead

---------

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2024-03-20 23:45:32 +01:00
Silvris
89739edf56 Merge branch 'instruction_patch_hotfix' into instruction_patch_kdl3 2024-03-20 16:37:29 -05:00
Silvris
3de7b88d4c Update Files.py 2024-03-20 16:28:39 -05:00
Silvris
e32bcb1cfc type hint cleanup 2024-03-20 16:20:28 -05:00
Silvris
0cbc81fd33 rename tokens to _tokens. use hasattr 2024-03-20 16:08:05 -05:00
Silvris
b15ecd5f88 fix classvar mixup 2024-03-20 16:06:37 -05:00
Silvris
59fca0bf81 fix missing tuple ellipsis 2024-03-20 15:50:42 -05:00
Silvris
be970d81ec move required_extensions to tuple 2024-03-20 14:46:18 -05:00
Silvris
f4ac421d51 Update worlds/Files.py
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2024-03-20 13:24:22 -05:00
Silvris
8620572562 Update worlds/Files.py
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2024-03-20 12:54:57 -05:00
Silvris
25e5e68a9d change class variables to instance variables 2024-03-19 18:18:59 -05:00
Silvris
94650a02de Core: implement APProcedurePatch and APTokenMixin (#2536)
* initial work on procedure patch

* more flexibility

load default procedure for version 5 patches
add args for procedure
add default extension for tokens and bsdiff
allow specifying additional required extensions for generation

* pushing current changes to go fix tloz bug

* move tokens into a separate inheritable class

* forgot the commit to remove token from ProcedurePatch

* further cleaning from bad commit

* start on docstrings

* further work on docstrings and typing

* improve docstrings

* fix incorrect docstring

* cleanup

* clean defaults and docstring

* define interface that has only the bare minimum required
for `Patch.create_rom_file`

* change to dictionary.get

* remove unnecessary if statement

* update to explicitly check for procedure, restore compatible version and manual override

* Update Files.py

* remove struct uses

* ensure returning bytes, add token type checking

* Apply suggestions from code review

Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>

* pep8

---------

Co-authored-by: beauxq <beauxq@yahoo.com>
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
2024-03-19 23:08:29 +01:00
Silvris
4e3f1509ac remove struct uses 2024-03-14 16:49:16 -05:00
Silvris
7c97a11521 Update Files.py 2024-03-14 16:38:11 -05:00
Silvris
2e55118711 Merge remote-tracking branch 'upstream/main' into instruction_patch_clean 2024-03-14 16:37:57 -05:00
Doug Hoskisson
e534abeab0 Core: add layer for patches that don't use Patch.py (#2889)
* Core: add layer for patches that don't use `Patch.py`

* bump container version

* APAutoPatchInterface name

* mystic quest change

* OoT and Adventure changes

* missed name in docstring

* container version compatibility
2024-03-14 22:29:29 +01:00
Silvris
6ddd2e2d15 Merge remote-tracking branch 'upstream/main' into instruction_patch_clean 2024-03-06 18:22:43 -06:00
Doug Hoskisson
ecec931e9f Core: fix (typing) mistake in PR #2887 (#2891)
I made this variable for more compatible and safer type narrowing, and then I didn't use if for the type narrowing.
2024-03-04 08:26:52 +01:00
Silvris
abdb90d52d update to explicitly check for procedure, restore compatible version and manual override 2024-03-03 15:26:51 -06:00
Doug Hoskisson
4e31e51d7a Core: clarify error message when reading an APContainer (#2887) 2024-03-03 20:09:06 +01:00
Silvris
debdabe595 remove unnecessary if statement 2024-02-29 12:42:37 -06:00
Silvris
4b8f31a749 change to dictionary.get 2024-02-28 23:19:14 -06:00
Doug Hoskisson
475e803500 Core: APPatch interface (#2808)
define interface that has only the bare minimum required
for `Patch.create_rom_file`
2024-02-15 00:23:05 +01:00
beauxq
bed93a054c define interface that has only the bare minimum required
for `Patch.create_rom_file`
2023-12-06 19:31:32 -08:00
Silvris
a89c20870c clean defaults and docstring 2023-11-30 04:00:41 -06:00
Silvris
d8ffad854c cleanup 2023-11-30 03:41:43 -06:00
Silvris
89799f0b59 Merge remote-tracking branch 'upstream/main' into instruction_patch_clean 2023-11-28 14:14:25 -06:00
Fabian Dill
ef7d8a6b4f Core: limit parallel APContainer writing (#2443)
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2023-11-13 06:46:40 +01:00
Silvris
06f05a450e fix incorrect docstring 2023-10-31 21:04:00 -05:00
Silvris
6bed682bfa improve docstrings 2023-09-10 00:50:51 -05:00
Silvris
f88ccd1447 further work on docstrings and typing 2023-09-09 23:51:21 -05:00
Silvris
ce35826da9 start on docstrings 2023-08-11 01:35:36 -05:00
Silvris
1fa8e72463 further cleaning from bad commit 2023-07-21 20:45:34 -05:00
Silvris
be74233e86 forgot the commit to remove token from ProcedurePatch 2023-07-21 20:42:35 -05:00
Silvris
18ede71e87 move tokens into a separate inheritable class 2023-07-21 16:57:15 -05:00
Silvris
dac5e5aaac pushing current changes to go fix tloz bug 2023-07-21 16:56:41 -05:00
Silvris
e0bc4cfa20 more flexibility
load default procedure for version 5 patches
add args for procedure
add default extension for tokens and bsdiff
allow specifying additional required extensions for generation
2023-07-21 16:56:41 -05:00
Silvris
3fbbb4f361 initial work on procedure patch 2023-07-21 16:56:37 -05:00
Alchav
30a4bcbbbe [Pokemon Red and Blue] Initial implementation (#1016) 2022-10-13 07:45:52 +02:00
Fabian Dill
61e39f355d Core remove legacy patch (#1047)
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
2022-09-30 00:36:30 +02:00