RuleBuilder: Optimize Has("Item", 0) (#6228)

rule_builder/rules.py

@@ -843,9 +843,12 @@ class Has(Rule[TWorld], game="Archipelago"):
 
     @override
     def _instantiate(self, world: TWorld) -> Rule.Resolved:
+        count = resolve_field(self.count, world, int)
+        if count <= 0:
+            return True_().resolve(world)
         return self.Resolved(
             resolve_field(self.item_name, world, str),
-            count=resolve_field(self.count, world, int),
+            count=count,
             player=world.player,
             caching_enabled=getattr(world, "rule_caching_enabled", False),
         )

test/general/test_rule_builder.py

@@ -167,6 +167,10 @@ class CachedRuleBuilderTestCase(RuleBuilderTestCase):
             Or(),
             False_.Resolved(player=1)
         ),
+        (
+            Has("A", 0),
+            True_.Resolved(player=1)
+        ),
         (
             And(Has("A", 1), Has("A", 2)),
             Has.Resolved("A", 2, player=1),