NewSoupVi 92ca11b729 Core: Prevent people from using LogicMixin incorrectly ...

There's a world that ran into some issues because it defined its custom LogicMixin variables at the class level.

This caused "instance bleed" when new CollectionState objects were created.

I don't think there is ever a reason to have a non-function class variable on LogicMixin without also having `init_mixin`, so this asserts that this is the case.

Tested:
Doesn't fail any current worlds
Correctly fails the world in question

Also, not gonna call out that world because it was literally my fault for explaining it to them wrong :D

2024-09-21 18:02:24 +02:00

..

_bizhawk

BizHawkClient: Avoid error launching BizHawkClient via Launcher CLI (#3554)

2024-09-18 20:42:22 +02:00

_sc2common

SC2: don't close all SC2 instances when one quits (#3507)

2024-06-12 02:14:30 +02:00

adventure

Various worlds: Fix more absolute world imports (#3510)

2024-06-27 08:51:27 +02:00

ahit

AHIT: Fix thug shops having 0 items after the first shop rolls 0 items (#3799)

2024-08-31 21:00:19 +02:00

alttp

ALTTP: Plando (#2904) fixes (#3834)

2024-09-09 15:56:15 +02:00

apsudoku

APSudoku: Update setup guide, remove extraneous options page link (#3849)

2024-08-29 08:12:58 +02:00

aquaria

Aquaria: Logic bug fixes (#3679)

2024-08-08 00:19:52 +02:00

archipidle

ArchipIDLE 2024 (#3079)

2024-04-12 00:32:10 -04:00

blasphemous

Blasphemous: Move pre_fill to create_items #3901

2024-09-17 15:08:15 +02:00

bomb_rush_cyberfunk

Bomb Rush Cyberfunk: Fix Coil quest being in glitched logic too early (#3720)

2024-07-31 17:32:51 +02:00

bumpstik

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

celeste64

Celeste 64: Typo #3840

2024-08-24 02:05:42 +02:00

checksfinder

ChecksFinder: itempool naming/typing (#3797)

2024-08-29 08:43:13 +02:00

clique

Clique: Update to new options API (#3759)

2024-08-11 14:47:17 +02:00

cv64

Core: Rework accessibility (#1481)

2024-07-31 12:13:14 +02:00

dark_souls_3

DS3: Make Red Eye Orb always require Lift Chamber Key #3857

2024-09-17 23:58:45 +02:00

dkc3

Various worlds: Fix more absolute world imports (#3510)

2024-06-27 08:51:27 +02:00

dlcquest

DLC Quest: Add options presets to DLC Quest (#3676)

2024-07-24 13:49:28 +02:00

doom_1993

DOOM, DOOM II: Update steam URLs (#3746)

2024-08-09 17:04:59 +02:00

doom_ii

DOOM II: Fix sector 95 assignment in DOOM II MAP17 to correctly flag the BFG9000 location as in the Yellow Key area (#3705)

2024-09-18 00:08:18 +02:00

factorio

Factorio: update API use (#3760)

2024-09-18 00:18:17 +02:00

ff1

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

ffmq

Docs: Add FFMQ French Setup Guide + Minor fixes to English Guide (#3590)

2024-07-31 17:40:45 +02:00

generic

Docs: Missed Full Accessibility mention/conversion #3734

2024-08-06 00:00:33 +02:00

heretic

Doom 2, Heretic: fix missing items (Doom2 Megasphere, Heretic Torch) (#3561)

2024-06-19 12:59:10 +02:00

hk

HK: add race bool to slot data (#3971)

2024-09-21 16:45:22 +02:00

hylics2

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

kdl3

KDL3: Account for additional animal in pool #3874

2024-09-04 15:19:00 +02:00

kh1

Kingdom Hearts: Fix Hint Spam and Add Setting Queries #3899

2024-09-19 22:32:47 +02:00

kh2

KH2: Update the docs to support steam in the setup guide (#3711)

2024-08-07 23:56:22 +02:00

ladx

LADX: define filler item, fix for extra golden leaves (#3918)

2024-09-20 16:18:09 +02:00

landstalker

Landstalker: Fixed rare generation issues (#3353)

2024-06-01 06:39:57 -05:00

lingo

Lingo: Added missing connection from The Tenacious -> Hub Room (#3947)

2024-09-16 18:06:20 +02:00

lufia2ac

CommonClient: Use lookup_in_game instead of lookup_in_slot in case of own-game name lookup when disconnected from server. (#3514)

2024-06-16 05:37:05 -05:00

meritous

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

messenger

The Messenger: Fix Portal Plando Issues (#3838)

2024-09-18 00:00:26 +02:00

minecraft

Minecraft: Update to new options system. (#3765)

2024-08-20 00:58:30 +02:00

mlss

MLSS: Various bugfixes and QoL updates (#3744)

2024-09-18 19:33:02 +02:00

mm2

MM2: fix Air Shooter minimum damage #3922

2024-09-17 14:42:19 +02:00

mmbn3

MMBN3: Add missing indirect conditions (#3931)

2024-09-17 14:41:56 +02:00

musedash

Muse Dash: Update to 4.7.0 - Let's Rhythm Jam! (#3837)

2024-08-24 18:19:42 +02:00

noita

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

oot

Ocarina of Time: options and general cleanup (#3767)

2024-09-18 21:26:59 +02:00

osrs

[OSRS] Adds display names to Options #3954

2024-09-20 16:15:30 +02:00

overcooked2

Various worlds: Fix more absolute world imports (#3510)

2024-06-27 08:51:27 +02:00

pokemon_emerald

Pokemon Emerald: Prevent client from spamming goal status update (#3900)

2024-09-17 23:49:36 +02:00

pokemon_rb

Pokemon R/B: Version 5 Update (#3566)

2024-09-18 20:37:17 +02:00

raft

Raft: Move to new Options API (#3587)

2024-07-15 15:09:02 +02:00

rogue_legacy

Rogue Legacy: Split Additional Names into two option classes #3908

2024-09-08 19:57:09 +02:00

ror2

RoR2: Remove recursion from explore mode access rules (#3681)

2024-08-07 23:57:07 +02:00

sa2b

Fix Incorrect Link Syntax in SA2B Linux Setup (#3524)

2024-06-13 06:53:01 +02:00

sc2

SC2: Fix /received display bugs (#3949)

2024-09-17 23:18:43 +02:00

shivers

Shivers: Add collect behavior option. (#3854)

2024-08-31 13:30:42 +02:00

shorthike

A Short Hike: Fix Boat Rental purchase being incorrectly calculated (#3639)

2024-07-22 01:47:46 +02:00

sm

SM and SMZ3 option_definitions deprecation fix (#3372)

2024-08-31 13:49:33 +02:00

sm64ex

sm64ex: Add missing indirect condition for BitFS randomized entrance (#3926)

2024-09-13 16:02:13 +02:00

smw

Various worlds: Fix more absolute world imports (#3510)

2024-06-27 08:51:27 +02:00

smz3

SM and SMZ3 option_definitions deprecation fix (#3372)

2024-08-31 13:49:33 +02:00

soe

SoE: fix determinism (#3745)

2024-08-10 13:08:24 +02:00

spire

Spire: Convert options, clean up random calls, and add DeathLink (#3704)

2024-07-31 18:27:35 +02:00

stardew_valley

Stardew Valley: Remove Accessibility and progression balancing from presets #3833

2024-09-18 00:07:40 +02:00

subnautica

Core: Region handling customization (#3682)

2024-09-05 16:32:45 +02:00

terraria

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

timespinner

Timespinner: Fix eels check logic #3777

2024-08-12 00:24:09 +02:00

tloz

TLOZ: Fix non-deterministic item pool generation (#3779)

2024-08-16 20:57:04 +02:00

tunic

TUNIC: Better logic for Library Lab glass and Fortress leaf piles #3880

2024-09-17 23:57:55 +02:00

undertale

Undertale: Fix slot_data and options.as_dict() (#3774)

2024-08-12 01:53:40 +02:00

v6

VVVVVV: Make unnecessary Trinkets filler (#3806)

2024-08-18 23:03:57 +02:00

wargroove

Wargroove: Switched to options API. (#3306)

2024-05-16 18:46:13 +02:00

witness

The Witness: Remove some unused code #3852

2024-09-19 01:57:59 +02:00

yachtdice

Yacht Dice: Remove Victory item and make it an event instead (#3968)

2024-09-20 19:07:45 +02:00

yoshisisland

Yoshi's Island: Fix client giving victory randomly (#3586)

2024-06-26 13:19:16 +02:00

yugioh06

YGO06: slotdata fix (#3953)

2024-09-17 15:13:19 +02:00

zillion

Zillion: fix logic cache (#3719)

2024-09-18 21:09:47 +02:00

zork_grand_inquisitor

Zork Grand Inquisitor: Fix Determinism Issues on Fixed Seeds (#3134)

2024-04-18 18:47:27 +02:00

__init__.py

Core: fix invalid __package__ of zipped worlds (#3686)

2024-08-10 13:49:32 +02:00

AutoSNIClient.py

SNIClient: dynamically generate patch file identifier (#2870)

2024-03-07 10:18:22 +01:00

AutoWorld.py

Core: Prevent people from using LogicMixin incorrectly

2024-09-21 18:02:24 +02:00

Files.py

APProcedurePatch: fix RLE/COPY incorrect sizing (#3006)

2024-03-22 09:02:38 +01:00

LauncherComponents.py

Launcher: explicitly handle cli arguments to be passed to the Component (#3714)

2024-09-08 18:13:01 +02:00