From b2949dfbe85ac18da113430fb1a545cb14b8c47e Mon Sep 17 00:00:00 2001 From: Silvris <58583688+Silvris@users.noreply.github.com> Date: Wed, 4 Sep 2024 08:19:00 -0500 Subject: [PATCH 1/3] KDL3: Account for additional animal in pool #3874 --- worlds/kdl3/__init__.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/worlds/kdl3/__init__.py b/worlds/kdl3/__init__.py index 12f56a0230..f01c82dd16 100644 --- a/worlds/kdl3/__init__.py +++ b/worlds/kdl3/__init__.py @@ -201,16 +201,13 @@ class KDL3World(World): else: animal_base = ["Rick Spawn", "Kine Spawn", "Coo Spawn", "Nago Spawn", "ChuChu Spawn", "Pitch Spawn"] animal_pool = [self.random.choice(animal_base) - for _ in range(len(animal_friend_spawns) - 9)] + for _ in range(len(animal_friend_spawns) - 10)] # have to guarantee one of each animal animal_pool.extend(animal_base) if guaranteed_animal == "Kine Spawn": animal_pool.append("Coo Spawn") else: animal_pool.append("Kine Spawn") - # Weird fill hack, this forces ChuChu to be the last animal friend placed - # If Kine is ever the last animal friend placed, he will cause fill errors on closed world - animal_pool.sort() locations = [self.multiworld.get_location(spawn, self.player) for spawn in spawns] items: List[Item] = [self.create_item(animal) for animal in animal_pool] allstate = CollectionState(self.multiworld) From b8d7ef24f78aed5a281d2b811244793496498160 Mon Sep 17 00:00:00 2001 From: Aaron Wagener Date: Wed, 4 Sep 2024 08:21:02 -0500 Subject: [PATCH 2/3] The Messenger: remove an invalid entrance (#3873) --- worlds/messenger/connections.py | 1 - 1 file changed, 1 deletion(-) diff --git a/worlds/messenger/connections.py b/worlds/messenger/connections.py index 978917c555..69dd7aa7f2 100644 --- a/worlds/messenger/connections.py +++ b/worlds/messenger/connections.py @@ -114,7 +114,6 @@ CONNECTIONS: Dict[str, Dict[str, List[str]]] = { "Forlorn Temple - Rocket Maze Checkpoint", ], "Rocket Maze Checkpoint": [ - "Forlorn Temple - Sunny Day Checkpoint", "Forlorn Temple - Climb Shop", ], }, From d65863ffa2f06ebdcc1b521a17b3e82f7ee0053e Mon Sep 17 00:00:00 2001 From: Bryce Wilson Date: Wed, 4 Sep 2024 11:00:47 -0700 Subject: [PATCH 3/3] Pokemon Emerald: Fix wrong place for initialization (#3870) --- worlds/pokemon_emerald/client.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/worlds/pokemon_emerald/client.py b/worlds/pokemon_emerald/client.py index 7f16015a3f..cda829def9 100644 --- a/worlds/pokemon_emerald/client.py +++ b/worlds/pokemon_emerald/client.py @@ -122,6 +122,7 @@ class PokemonEmeraldClient(BizHawkClient): game = "Pokemon Emerald" system = "GBA" patch_suffix = ".apemerald" + local_checked_locations: Set[int] local_set_events: Dict[str, bool] local_found_key_items: Dict[str, bool] @@ -139,8 +140,7 @@ class PokemonEmeraldClient(BizHawkClient): current_map: Optional[int] - def __init__(self) -> None: - super().__init__() + def initialize_client(self): self.local_checked_locations = set() self.local_set_events = {} self.local_found_key_items = {} @@ -182,9 +182,7 @@ class PokemonEmeraldClient(BizHawkClient): ctx.want_slot_data = True ctx.watcher_timeout = 0.125 - self.death_counter = None - self.previous_death_link = 0 - self.ignore_next_death_link = False + self.initialize_client() return True