From b34b84aa8f4fb96b466596d49f920834c95ca941 Mon Sep 17 00:00:00 2001 From: Severencir <62644089+Severencir@users.noreply.github.com> Date: Thu, 30 Jul 2026 08:25:11 -0500 Subject: [PATCH] Starcraft 2: item pool reduction overcounting fix (#6318) --- worlds/sc2/pool_filter.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/worlds/sc2/pool_filter.py b/worlds/sc2/pool_filter.py index abecf8264c..3068034b93 100644 --- a/worlds/sc2/pool_filter.py +++ b/worlds/sc2/pool_filter.py @@ -146,7 +146,11 @@ class ValidInventory: return sum(self.logical_inventory.get(item, 0) for item in items) def count_from_list_unique(self, items: Iterable[str], player: int) -> int: - return sum(item in self.logical_inventory for item in items) + result = 0 + for item in items: + if self.logical_inventory[item] > 0: + result += 1 + return result def generate_reduced_inventory(self, inventory_size: int, filler_amount: int, mission_requirements: List[Tuple[str, Callable]]) -> List[StarcraftItem]: """Attempts to generate a reduced inventory that can fulfill the mission requirements."""