From a9fb7e2ace12508d6fdf9d4b2220cde1483f3582 Mon Sep 17 00:00:00 2001
From: Silvris <58583688+Silvris@users.noreply.github.com>
Date: Mon, 31 Jul 2023 16:16:42 -0500
Subject: [PATCH] Plando: fix automatic locations only working for the first
 world (#2063)

* copy location_names for each iteration

* remove copy, just set the list
---
 BaseClasses.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/BaseClasses.py b/BaseClasses.py
index 7c12a94dea..02d050c667 100644
--- a/BaseClasses.py
+++ b/BaseClasses.py
@@ -487,8 +487,10 @@ class MultiWorld():
     def get_unfilled_locations_for_players(self, location_names: List[str], players: Iterable[int]):
         for player in players:
             if not location_names:
-                location_names = [location.name for location in self.get_unfilled_locations(player)]
-            for location_name in location_names:
+                valid_locations = [location.name for location in self.get_unfilled_locations(player)]
+            else:
+                valid_locations = location_names
+            for location_name in valid_locations:
                 location = self._location_cache.get((location_name, player), None)
                 if location is not None and location.item is None:
                     yield location