From a6cb77b00307beb100773c51c7088a487cec1cfa Mon Sep 17 00:00:00 2001 From: Jarno Westhof Date: Mon, 14 Jul 2025 20:03:49 +0200 Subject: [PATCH] Restore tests to original state --- test/general/test_ids.py | 2 -- test/general/test_reachability.py | 6 ++---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/test/general/test_ids.py b/test/general/test_ids.py index b7c8ef2f71..ad8aad11d1 100644 --- a/test/general/test_ids.py +++ b/test/general/test_ids.py @@ -65,8 +65,6 @@ class TestIDs(unittest.TestCase): def test_duplicate_location_ids(self): """Test that a game doesn't have location id overlap within its own datapackage""" for gamename, world_type in AutoWorldRegister.world_types.items(): - self.maxDiff = None - with self.subTest(game=gamename): len_location_id_to_name = len(world_type.location_id_to_name) len_location_name_to_id = len(world_type.location_name_to_id) diff --git a/test/general/test_reachability.py b/test/general/test_reachability.py index 3210daeabe..b45a2bdfc0 100644 --- a/test/general/test_reachability.py +++ b/test/general/test_reachability.py @@ -52,8 +52,7 @@ class TestBase(unittest.TestCase): state = multiworld.get_all_state(False) for location in multiworld.get_locations(): with self.subTest("Location should be reached", location=location.name): - if not location.can_reach(state): - self.assertTrue(location.can_reach(state), f"{location.name} unreachable") + self.assertTrue(location.can_reach(state), f"{location.name} unreachable") for region in multiworld.get_regions(): if region.name in unreachable_regions: @@ -61,8 +60,7 @@ class TestBase(unittest.TestCase): self.assertFalse(region.can_reach(state)) else: with self.subTest("Region should be reached", region=region.name): - if not region.can_reach(state): - self.assertTrue(region.can_reach(state)) + self.assertTrue(region.can_reach(state)) with self.subTest("Completion Condition"): self.assertTrue(multiworld.can_beat_game(state))