From a035ac579c30f6623531902da4cc02b5ed132f3e Mon Sep 17 00:00:00 2001 From: Mysteryem Date: Sun, 18 Jan 2026 13:47:55 +0000 Subject: [PATCH] Noita: Fix filling Shop Item locations without updating item.location (#5840) In single-player multiworlds with small item pools, Noita was manually placing some items into Shop Item locations, but was only setting location.item, and not also setting item.location so that the item and location refer to one another. This has been fixed by using the MultiWorld.push_item() helper method to place the items instead of manually placing the items. --- worlds/noita/items.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worlds/noita/items.py b/worlds/noita/items.py index 4cd0b5ef87..740ce587fe 100644 --- a/worlds/noita/items.py +++ b/worlds/noita/items.py @@ -79,7 +79,7 @@ def create_all_items(world: NoitaWorld) -> None: if world.multiworld.players == 1: for location in world.multiworld.get_unfilled_locations(player): if "Shop Item" in location.name: - location.item = create_item(player, itempool.pop()) + world.multiworld.push_item(location, create_item(player, itempool.pop()), False) locations_to_fill = len(world.multiworld.get_unfilled_locations(player)) itempool += create_random_items(world, filler_weights, locations_to_fill - len(itempool))