mirror/Archipelago
1
0
Fork 1
mirror of https://github.com/ArchipelagoMW/Archipelago.git synced 2026-05-27 14:59:56 -07:00
Code Issues Packages Projects Releases Wiki Activity

Stardew Valley: Improve generation performance by around 11% by moving calculating from rule evaluation to collect (#4231)

Browse Source
This commit is contained in:
Jouramie
2025-01-18 20:36:01 -05:00
committed by GitHub
parent 1c9409cac9
commit 992f192529
4 changed files with 42 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
worlds/stardew_valley/test/rules/TestShipping.py
+7 -4
View File
@@ -69,14 +69,17 @@ class TestShipsanityEverything(SVTestBase):
def test_all_shipsanity_locations_require_shipping_bin(self):
bin_name = "Shipping Bin"
self.collect_all_except(bin_name)
shipsanity_locations = [location for location in self.get_real_locations() if
LocationTags.SHIPSANITY in location_table[location.name].tags]
shipsanity_locations = [location
for location in self.get_real_locations()
if LocationTags.SHIPSANITY in location_table[location.name].tags]
bin_item = self.create_item(bin_name)
for location in shipsanity_locations:
with self.subTest(location.name):
self.remove(bin_item)
self.assertFalse(self.world.logic.region.can_reach_location(location.name)(self.multiworld.state))
self.multiworld.state.collect(bin_item)
self.collect(bin_item)
shipsanity_rule = self.world.logic.region.can_reach_location(location.name)
self.assert_rule_true(shipsanity_rule, self.multiworld.state)
self.remove(bin_item)