From 614c50e495bfcdb46d355e99b09b79c91c5e0d3f Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Fri, 19 Aug 2022 18:39:32 -0400 Subject: [PATCH] Attempt to make the WebHost change guide describe the intent of the style restrictions more accurately. --- WebHostLib/README.md | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/WebHostLib/README.md b/WebHostLib/README.md index 5e97ed0486..22bb8c605d 100644 --- a/WebHostLib/README.md +++ b/WebHostLib/README.md @@ -8,8 +8,10 @@ team and the community. The current primary maintainer of the website is Farrak He may be found on Discord as `Farrak Kilhn#0418`, or on GitHub as `LegendaryLinux`. ### Small Changes -Pull requests for small changes to the website are almost always accepted. These include things -like spelling and grammar corrections, bugfixes, etc. +Little changes like adding a button or a couple new select elements are perfectly fine. +Tweaks to style specific to a PR's content are also probably not a problem. For example, if +you build a new page which needs two side by side tables, and you need to write a CSS file +specific to your page, that is perfectly reasonable. ### Content Additions Once you develop a new feature or add new content the website, make a pull request. It will @@ -17,12 +19,21 @@ be reviewed by the community and there will probably be some discussion around i on the size of the feature, and if new styles are required, there may be an additional step before the PR is accepted wherein Farrak works with the designer to implement styles. -### Style Changes -While content and feature changes to the website are commonly accepted, style changes are not. -A professional designer has designed the assets, colors, themes, etc. for the website. In an -effort to maintain a consistent look and feel, style changes are largely not accepted. Please -note this applies to code which changes the look and feel of the site, not to small tweaks to -CSS for your custom page. +### Restrictions on Style Changes +Pull requests which change the overall look and feel of the website are rejected. A +professional designer is paid to develop the styles and assets for the Archipelago website. +In an effort to maintain a consistent look and feel, pull requests which exclusively change +site styles are typically rejected as well. Please note this applies to code which changes +the look and feel of the site, not to small tweaks to CSS for your custom page. It is +therefore worth noting there are a couple files which, if changed in your pull request, +will cause it to draw additional scrutiny. + +These closely guarded files are: +- `globalStyles.css` +- `islandFooter.css` +- `landing.css` +- `markdown.css` +- `tooltip.css` ### Site Themes There are several themes available for game pages. It is possible to request a new theme in