From 45994e344e8a262202cf58167a4fe25c9c38c912 Mon Sep 17 00:00:00 2001 From: Silvris <58583688+Silvris@users.noreply.github.com> Date: Tue, 16 Dec 2025 12:27:02 -0600 Subject: [PATCH] Tests: test that every option in a preset is visible in either simple or complex UI (#5750) --- test/webhost/test_option_presets.py | 5 ++++- worlds/kdl3/presets.py | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/test/webhost/test_option_presets.py b/test/webhost/test_option_presets.py index efacddb22e..7f05de5d11 100644 --- a/test/webhost/test_option_presets.py +++ b/test/webhost/test_option_presets.py @@ -2,7 +2,7 @@ import unittest from BaseClasses import PlandoOptions from worlds import AutoWorldRegister -from Options import OptionCounter, NamedRange, NumericOption, OptionList, OptionSet +from Options import OptionCounter, NamedRange, NumericOption, OptionList, OptionSet, Visibility class TestOptionPresets(unittest.TestCase): @@ -19,6 +19,9 @@ class TestOptionPresets(unittest.TestCase): # pass in all plando options in case a preset wants to require certain plando options # for some reason option.verify(world_type, "Test Player", PlandoOptions(sum(PlandoOptions))) + if not (Visibility.complex_ui in option.visibility or Visibility.simple_ui in option.visibility): + self.fail(f"'{option_name}' in preset '{preset_name}' for game '{game_name}' is not " + f"visible in any supported UI.") supported_types = [NumericOption, OptionSet, OptionList, OptionCounter] if not any([issubclass(option.__class__, t) for t in supported_types]): self.fail(f"'{option_name}' in preset '{preset_name}' for game '{game_name}' " diff --git a/worlds/kdl3/presets.py b/worlds/kdl3/presets.py index 491ad9dca9..f07973e6b0 100644 --- a/worlds/kdl3/presets.py +++ b/worlds/kdl3/presets.py @@ -7,7 +7,7 @@ all_random = { "game_language": "random", "goal": "random", "goal_speed": "random", - "total_heart_stars": "random", + "max_heart_stars": "random", "heart_stars_required": "random", "filler_percentage": "random", "trap_percentage": "random", @@ -34,7 +34,7 @@ all_random = { beginner = { "goal": "zero", "goal_speed": "normal", - "total_heart_stars": 50, + "max_heart_stars": 50, "heart_stars_required": 30, "filler_percentage": 25, "trap_percentage": 0,